Reviewing Compiler Prs
Testing & Qualityreviewing-compiler-prsReviewing Compiler Prs is an Agent Skill for testing & quality published in the dotnet/dotnet repository on GitHub: a SKILL.md instruction file an AI agent can load to do this task.
Performs multi-agent, multi-model code review of F# compiler PRs across 19 dimensions including type checking, IL emission, binary compatibility, and IDE performance. Dispatches parallel assessment agents per dimension, consolidates with cross-model agreement scoring, and filters false positives. Invoke when reviewing compiler changes, requesting expert feedback, or performing pre-merge quality checks.
How to use this skill
Bring this guide into your coding agent with a prompt tailored to the tool you use.
- Open your project in Codex.
- Copy and paste the prompt below.
- Review files and risks before approving any action.
Inspect the Agent Skill at https://github.com/dotnet/dotnet/blob/HEAD/src/fsharp/.github/skills/reviewing-compiler-prs/SKILL.md and all supporting files. Report provenance, permissions, scripts, dependencies, and security risks. Propose an exact installation into .agents/skills/reviewing-compiler-prs, but wait for my approval before writing files or running scripts.
Copying this prompt does not install or run the skill. Review third-party files before use.
Reviewing Compiler PRs
Full dimension definitions and CHECK rules live in the expert-reviewer agent.
When to Invoke
- PR touches
src/Compiler/— invoke theexpert-revieweragent - PR touches
src/FSharp.Core/— focus on FSharp.Core Stability, API Surface, Backward Compat, XML Docs - PR touches
vsintegration/orLanguageServer/— focus on IDE Responsiveness, Concurrency, Memory - PR touches
tests/only — quick check: baselines explained? Cross-TFM coverage? Tests actually assert? - PR touches
eng/or build scripts — focus on Build Infrastructure, Cross-Platform
Dimension Selection
| Files Changed | Focus Dimensions |
|---|---|
Checking/, TypedTree/ | Type System, Overload Resolution, Struct Awareness, Feature Gating |
CodeGen/, AbstractIL/ | IL Emission, Debug Experience, Test Coverage |
Optimize/ | Optimization Correctness, IL Emission, Test Coverage |
SyntaxTree/, pars.fsy | Parser Integrity, Feature Gating, Typed Tree Discipline |
TypedTreePickle.*, CompilerImports.* | Binary Compatibility (highest priority) |
Service/ | FCS API Surface, IDE Responsiveness, Concurrency, Incremental Checking |
LanguageServer/ | IDE Responsiveness, Concurrency |
Driver/ | Build Infrastructure, Incremental Checking, Cancellation |
Facilities/ | Feature Gating, Concurrency |
FSComp.txt | Diagnostic Quality |
FSharp.Core/ | FSharp.Core Stability, Backward Compat, XML Docs, RFC Process |
vsintegration/ | IDE Responsiveness, Memory Footprint, Cross-Platform |
eng/, setup/, build scripts | Build Infrastructure, Cross-Platform |
Subagent Dispatch
For each selected dimension from the table above, the expert-reviewer agent MUST launch an independent subagent (background task) to assess that dimension. This is not optional — a single agent doing all dimensions sequentially produces shallow analysis and wall-of-text summaries.
Each subagent receives:
- The dimension's CHECK rules (from expert-reviewer.md)
- The relevant file diffs (filtered by the dimension's hotspot paths)
- Instructions to produce a structured finding:
{file, line, severity, dimension, issue, suggestion}orLGTMif no findings
The expert-reviewer consolidates subagent results, deduplicates, applies assessment gates, and posts as inline comments per Wave 5.
Assessment gates — apply before flagging:
- Understand execution context before judging (test harness ≠ compiler runtime)
- Classify as regression, improvement, or unclear — only regressions are findings
- Require a concrete failing scenario — no hypotheticals
- "Correct convention" for the context in use → discard, not a finding
- "Unexplained" ≠ "wrong" — missing rationale in a commit message is a doc gap, not a defect
Consolidation:
- Deduplicate findings at same location
- Filter: wrong context → discard; improvement → downgrade; speculation → LOW
- Classify: Behavioral (correctness) → Quality (structure) → Nitpick (style)
- Rank by cross-model agreement (≥2 models agree = higher confidence)
- Present Behavioral first; Nitpicks only if nothing higher — agents love producing nitpicks to have something to say, deprioritize them
Self-Review Checklist
- Every behavioral change has a test
- FSharp.Core changes maintain binary compatibility
- No unintended public API surface changes
- New language features have a
LanguageFeatureguard and RFC - No raw
TType_*matching withoutstripTyEqns - Cancellation tokens threaded through async operations
- Cleanup changes separate from feature enablement
Full dimension CHECK rules are in the expert-reviewer agent.