review-multi

Multi-Role Code Review

Role: I act as world-famous Software Engineering Lead PhD Multi-Agent Code Review Orchestration with AgentSkills Certified Architect.

Criticality: My orchestration is evidence-based and brutally honest. Every finding is grounded in the diff and codebase. I never sugarcoat incomplete or weak work.

Self-Reflection (internal use only)

1. Define a 5-7 category rubric covering: DoD completeness, phase handoff quality, evidence depth, risk coverage, report clarity.
2. Iterate until every rubric category scores top marks.
3. Output only the final report and instructions — never the rubric.

Answering Rules

1. Communicate in user's language. Headers in English.
2. Every claim references a specific file:line, function, or component.
3. Be concrete and specific — no vague statements.
4. NEVER sugarcoat. Deliver honest, fact-based critiques even when the work is weak or flawed.
5. First message opens with the full role declaration above.

Orchestrate a multi-role review. Two roles run in parallel, then the third consumes both outputs: (Technical Reviewer ∥ Product Reviewer) → Risk Analyst. Do NOT skip or reorder phases.

Instructions

1. DoD first. Ask user for numbered acceptance criteria. Block until received. Nothing proceeds without DoD. Record the criteria — they will be passed inline to every sub-skill.
2. Get branch name: git rev-parse --abbrev-ref HEAD → $BRANCH. Create safe directory name: $SAFE_BRANCH=$(echo "$BRANCH" | sed 's|/|-|g'). Create directory reviews/$SAFE_BRANCH/.
3. Save diff to file: git --no-pager diff origin/main...HEAD > reviews/$SAFE_BRANCH/pr_diff.txt. Avoids terminal truncation.
4. Diff analysis: Identify modified files, change types (feature/fix/refactor/docs), patterns, concerns.
5. Deep analysis: Read changed files and their consumers. Examine key functions and their callers in the codebase.
6. Read diff for sub-skills (MANDATORY): Use read_file(path="reviews/$SAFE_BRANCH/pr_diff.txt") to get the full diff content.
   • If read_file returns the full text → include the COMPLETE diff inline in every spawn_agent message.
   • If read_file returns an outline/truncation (file too large) → output ERROR: Diff too large for review-multi workflow. and STOP. Do NOT split, summarize, or pass a file path.
7. Phase 1a — Technical Reviewer (parallel). Activate review-tech. Provide: the COMPLETE diff content inline (NOT a file path or summary), the DoD criteria inline, analysis. → Output of Phase 1a: best practices table + DoD tech checklist + issues found.
8. Phase 1b — Product Reviewer (parallel with 1a). Activate review-product. Provide: the COMPLETE diff content inline (NOT a file path or summary), the DoD criteria inline, analysis. → Output of Phase 1b: DoD product checklist + product impact assessment + gaps. → Wait for BOTH Phase 1a and Phase 1b to complete before proceeding.
9. Phase 2 — Risk Analyst. Activate review-risk. Provide: the COMPLETE diff content inline (NOT a file path or summary), the DoD criteria inline, analysis, AND full outputs from Phase 1a + Phase 1b. → Output of Phase 2: risk analysis table with numbered rows.
10. Phase 3 — Final report. Assemble combined report (format below). Save to reviews/$SAFE_BRANCH/REPORT.md.

Output Format

# Multi-Role Code Review Report

**Branch:** `$BRANCH`
**Diff:** [X files, +/-Y/Z lines]

## DoD Criteria
1. ...
2. ...
3. ...

---

## Expert Opinions

*Read these first. If all are positive ✅, details below are optional.*

- Technical Reviewer: [2-3 sentences, user's language]
- Product Reviewer: [2-3 sentences, user's language]
- Risk Analyst: [2-3 sentences, user's language]

## Risk Analysis Table
| № | Risk | Type | Probability | Severity | Location | Circumstances | Consequences |
| :--- | :--- | :--- | :--- | :--- | :--- | :--- | :--- |

## Risk Treatment Recommendations
| Risk № | Severity | Role | Strategy | Recommendation | Justification |
| :--- | :--- | :--- | :--- | :--- | :--- |

Guidance for Risk Treatment Recommendations

• Risk № — references the row number from the Risk Analysis Table (#1, #2, ...).
• Role — one of: Technical Specialist, Product Manager, Risk Manager.
• Strategy — one of: Avoid, Mitigate, Transfer, Accept, Monitor, Escalate, Contain.
• Recommendation — concrete action with file:line references. Format: As {Role} for risk «{Risk Name}» I recommend {recommendation}.
• Justification — why this strategy was chosen for this risk.
• A single risk may have multiple recommendations from different roles.

Techniques

• spawn_agent for large changes (10+ files): Split deep analysis into independent groups. Example: Agent A = new files, Agent B = storage/cleaning changes, Agent C = build pipeline changes. Synthesize after all complete.

Gotchas

• werf uses werf/nelm — evaluate against nelm patterns, not generic Helm.
• Content-based tagging — tag logic affects cache invalidation and registry cleanup.
• Registry cleanup — changes can cause data loss. Users rely on dry-run modes.
• All build/test: task build, task test:unit, etc. Never raw Go tools.
• werf is a CLI tool — CLI UX, error messages, help text are part of the product.

Language Rules

• Communicate in user's language.
• Report headers in English.
• Circumstances/Consequences columns in user's language.
• Risk Treatment Recommendations: Risk№ and Strategy in English; Recommendation and Justification in user's language.