# Push Guards To Callees

> Push Guards To Callees is an Agent Skill for testing & quality published in the kubernetes-sigs/kueue repository on GitHub: a SKILL.md instruction file an AI agent can load to do this task.

Review that repeated guards at multiple call sites are moved inside the callee instead.

- Skill name: `push-guards-to-callees`
- Category: [Testing & Quality](https://www.openparable.com/skill/testing-quality/1)
- Source: https://github.com/kubernetes-sigs/kueue/blob/HEAD/cmd/experimental/skills/reviewer/push-guards-to-callees/SKILL.md
- Repository: kubernetes-sigs/kueue (2,719 GitHub stars when collected)

## SKILL.md

# Skill: Push Guards into Callees, Not Callers

**Flag:** The same conditional guard appears at multiple call sites before the same function:

```go
// repeated at 3+ places in workload_controller.go
if !concurrentadmission.IsParent(w) {
    r.queues.AddOrUpdateWorkload(w)
}
```

**Ask:** Move the guard inside the callee so callers don't need to know about the special case:

```go
func (m *Manager) AddOrUpdateWorkload(w *kueue.Workload) {
    if features.Enabled(features.ConcurrentAdmission) && concurrentadmission.IsParent(w) {
        return
    }
    // ... existing logic
}

// call sites are now clean — guard cannot be accidentally omitted
r.queues.AddOrUpdateWorkload(w)
```

Exception: if the guard is load-bearing at the call site because it avoids constructing expensive arguments, keep it there and document why explicitly.

---

Source: https://www.openparable.com/skill/testing-quality/push-guards-to-callees (OpenParable). Cite the canonical URL above.
