Pre Submit PR
Testing & Qualitypre-submit-prPre Submit PR is an Agent Skill for testing & quality published in the natolambert/rlhf-book repository on GitHub: a SKILL.md instruction file an AI agent can load to do this task.
Validate changes before PR submission
How to use this skill
Bring this guide into your coding agent with a prompt tailored to the tool you use.
- Open your project in Codex.
- Copy and paste the prompt below.
- Review files and risks before approving any action.
Inspect the Agent Skill at https://github.com/natolambert/rlhf-book/blob/HEAD/.claude/skills/pre-submit-pr/SKILL.md and all supporting files. Report provenance, permissions, scripts, dependencies, and security risks. Propose an exact installation into .agents/skills/pre-submit-pr, but wait for my approval before writing files or running scripts.
Copying this prompt does not install or run the skill. Review third-party files before use.
/pre-submit-pr
Validate changes before submitting a pull request.
Usage
/pre-submit-pr
Instructions
-
Lint & format (for changes under
code/):cd "$(git rev-parse --show-toplevel)/code" && uvx [email protected] check . && uvx [email protected] format --check .Auto-fix with
uvx [email protected] check --fix .anduvx [email protected] format .if issues are found. The[email protected]pin matches.github/workflows/lint.yml; unpinneduvx ruffcan diverge from CI. -
Changelog (for changes under
code/): CI requirescode/CHANGELOG.mdto be modified for any PR touchingcode/(format is convention, not enforced). Check that an entry exists under## Unreleasedfor this PR, format:- YYYY-MM-DD: [PR #N](https://github.com/natolambert/rlhf-book/pull/N) description. -
Run code review (for significant changes): Invoke
pr-review-toolkit:review-prfor deeper analysis. Include findings in the report under a "### Code Review" section. -
Summarize PR readiness
Output Format
## Pre-Submit PR Report
### Automated Checks
| Check | Status | Details |
|-------|--------|---------|
| Ruff lint | PASS/FAIL | [details] |
| Ruff format | PASS/FAIL | [details] |
| Changelog | PASS/MISSING | [details] |
### Code Review
[pr-review-toolkit:review-pr findings, if run]
### Verdict: READY FOR PR / ISSUES TO ADDRESS
### Summary for PR Description
[2-3 sentences summarizing changes]
Blocking Issues
These block PR submission:
- Ruff lint or format failures (CI-enforced)
- Missing changelog entry in
code/CHANGELOG.md(CI-enforced: file must be modified)
Non-Blocking (Flag for Reviewers)
Note in PR but don't block:
- some TODOs in code (unless excessive)
- some print statements (unless excessive)