Lint Review
Testing & Qualitylint-reviewLint Review is an Agent Skill for testing & quality published in the marin-community/marin repository on GitHub: a SKILL.md instruction file an AI agent can load to do this task.
In CI, run the infra/lint catalog review over a PR.
How to use this skill
Bring this guide into your coding agent with a prompt tailored to the tool you use.
- Open your project in Codex.
- Copy and paste the prompt below.
- Review files and risks before approving any action.
Inspect the Agent Skill at https://github.com/marin-community/marin/blob/HEAD/.agents/skills/lint-review/SKILL.md and all supporting files. Report provenance, permissions, scripts, dependencies, and security risks. Propose an exact installation into .agents/skills/lint-review, but wait for my approval before writing files or running scripts.
Copying this prompt does not install or run the skill. Review third-party files before use.
Skill: Lint-catalog review on a PR
Run the infra/lint/ catalog review (./infra/pre-commit.py --review)
over a pull request's branch diff and surface every finding — as file:line
inline review comments where the finding's line is available, and as a
single fallback comment for the rest.
Your contract
You are running the review and reporting its output. You are read-only except
for posting comments: never edit, stage, commit, push, or "fix" anything, and
never run a state-changing git/gh command. The review's own lane agents are
already locked read-only.
Report the findings faithfully. The --review run (its lanes + composer) is
the authority on what is a finding: post each surviving finding verbatim —
one comment per finding. Do not drop, merge, reword the substance of, soften,
re-judge, or invent findings. Silently losing a real finding is the one
unforgivable error; so is fabricating one.
Steps
-
Idempotency guard (only with
--comment). Check whether this skill has already posted on the PR: look for the marker<!-- marin-lint-review -->in both issue comments (gh pr view <PR> --json comments) and inline review comments (gh api repos/{owner}/{repo}/pulls/<PR>/comments --paginate). If the marker is present, stop now — the PR already has a lint pass and we do not want duplicate comments. Otherwise continue. -
Run the review. From the repo root:
./infra/pre-commit.py --reviewThe command writes its raw per-arm prompts/outputs and the combined findings under
/tmp/marin-linter/<branch>/<timestamp>-<uniq>/(path printed at the end); read it if a run looks wrong. -
Collect the findings. Each finding the command emits on stdout is one line in the canonical catalog format:
<path>:<line>: ml-<code> (<confidence>) <message>e.g.
lib/iris/src/iris/foo.py:42: ml-cruft-dead-branch (0.85) Unreachable else after early return. -
No findings vs. failed run. Distinguish two zero-finding cases:
- Clean — the command exited 0 and printed
Lint review: no findings.(or emitted no finding lines). Post nothing: the green job check is the "lint pass clean" signal, and a second "all clear" comment would only duplicate the high-level review. State "Lint review: no findings." to the terminal and stop. - Failed to run — the command exited non-zero or printed that every lane failed / the agent was not found / the merge-base could not be resolved. Do not report this as clean. State plainly in your final output that the lint review could not run and why; post no comments. (A broken run is a job-log signal, not a PR comment.)
(Without
--comment: just print the findings, if any, to the terminal and stop here regardless.) - Clean — the command exited 0 and printed
-
Post inline comments. With
--commentand findings present, for each finding post one inline comment withmcp__github_inline_comment__create_inline_comment, the finding'spathandline, and a body of exactly this shape:`ml-<code>` · confidence <confidence> <message> <!-- marin-lint-review -->The
<message>is copied verbatim from the finding. Post one comment per finding; never post two comments for the same finding. -
Handle un-anchorable findings. The inline-comment tool rejects a line that is not part of the PR diff (it raises a validation error). A finding can land on such a line — e.g. the holistic
metalane anchors on context outside the added hunks. When a post fails for that reason, do not abort: record that finding and keep going through the rest. -
Fallback summary. After attempting every inline comment, if any findings could not be placed inline, post one issue comment with
gh pr comment <PR>so none are dropped. Format:Lint review: These infra/lint findings anchor on lines not in the PR diff, so they could not be attached inline. - <path>:<line>: ml-<code> (<confidence>) <message> - ... <!-- marin-lint-review -->List every un-anchorable finding verbatim. If every finding was placed inline, do not post this comment.
Notes
- Use the
ghCLI for GitHub; do not web-fetch. - The review reads the branch diff against the merge base with
origin/main, covering committed and uncommitted work. CI checks out the PR head and fetchesorigin/mainbefore invoking you, so the merge base resolves.