Frb PR Review
Testing & Qualityfrb-pr-reviewFrb PR Review is an Agent Skill for testing & quality published in the fzyzcjy/flutter_rust_bridge repository on GitHub: a SKILL.md instruction file an AI agent can load to do this task.
Review a flutter_rust_bridge PR before treating it as ready, including subagent checks for correctness and test weakening plus Gemini review.
How to use this skill
Bring this guide into your coding agent with a prompt tailored to the tool you use.
- Open your project in Codex.
- Copy and paste the prompt below.
- Review files and risks before approving any action.
Inspect the Agent Skill at https://github.com/fzyzcjy/flutter_rust_bridge/blob/HEAD/.claude/skills/frb-pr-review/SKILL.md and all supporting files. Report provenance, permissions, scripts, dependencies, and security risks. Propose an exact installation into .agents/skills/frb-pr-review, but wait for my approval before writing files or running scripts.
Copying this prompt does not install or run the skill. Review third-party files before use.
FRB PR Review
Use this before treating a non-trivial flutter_rust_bridge PR as ready, especially after CI-driven fixes, Flutter upgrades, generated drift, test changes, workflow changes, or broad merge conflict resolution.
Review Gate
Run independent review before final readiness:
-
Spawn a subagent to review correctness.
- Ask it to inspect the PR diff against the PR base.
- Focus on real behavior bugs, stale generated output, incorrect CI workarounds, coverage-only changes, and unrelated drift.
- Require findings with file paths, line numbers, impact, and suggested fix.
-
Spawn a subagent to review test weakening.
- Use the test-weakening gate described in
sdev-pass-testas the source of truth. - Do not duplicate that workflow here; read
sdev-pass-testfor detection, classification, and restoration details. - Treat unjustified skipped tests, weaker assertions, broader ignores, fake timeouts, and coverage hiding as blockers.
- Use the test-weakening gate described in
-
Ask Gemini for an external review.
- Post
/gemini reviewwhen the PR is reasonably ready. - Inspect Gemini's review/comments.
- Fix valid feedback, commit, push, and explain invalid feedback in a concise PR comment.
- Request another Gemini pass after substantial follow-up fixes.
- Post
-
Write a concise review conclusion.
- Put the conclusion in the PR description or an agent-context draft when the user asks for a Markdown artifact.
- Include the subagents used, Gemini status, accepted findings, dismissed findings, fixes made, and remaining risks.
Stop Condition
Do not call the PR ready until:
- Correctness review has no unresolved actionable findings.
- Test-weakening review has no unjustified weakening.
- Gemini has no unresolved actionable feedback after the latest requested pass.
- CI status is green, or remaining non-green checks are clearly unrelated and explained.