OpenParable
Skip to content
← Back to skills

Fboss Review

Testing & Quality
fboss-review

Fboss Review is an Agent Skill for testing & quality published in the facebook/fboss repository on GitHub: a SKILL.md instruction file an AI agent can load to do this task.

Comprehensive FBOSS code review with 11 parallel reviewers (5 generic + 6 FBOSS-specific). Covers reliability, engineering, code quality, silent failures, agent architecture, SAI/SDK, FSDB/thrift_cow, platform/config, testing, and cross-cutting design. Self-contained alternative to /review-diff for FBOSS diffs. Findings shown to user only, never auto-posted.

View on GitHub ↗
QUICK START

How to use this skill

Bring this guide into your coding agent with a prompt tailored to the tool you use.

  1. Open your project in Codex.
  2. Copy and paste the prompt below.
  3. Review files and risks before approving any action.
Prompt to paste
Inspect the Agent Skill at https://github.com/facebook/fboss/blob/HEAD/fboss/skills/fboss-review/SKILL.md and all supporting files. Report provenance, permissions, scripts, dependencies, and security risks. Propose an exact installation into .agents/skills/fboss-review, but wait for my approval before writing files or running scripts.

Copying this prompt does not install or run the skill. Review third-party files before use.

FBOSS Review

Overview

Multi-reviewer code review for FBOSS diffs. Subsumes general review (/review-diff functionality) plus FBOSS-specific domain expertise.

Scope

Currently fboss/ only. TODO: extend to configerator/source/neteng/fboss, neteng/netcastle, neteng/fboss.

IMPORTANT: No Auto-Posting

All findings are shown to the user only. Never post to Phabricator automatically.

Review Workflow

Step 1: Identify Changes

  • Run sl status and sl diff to get changed files
  • If user specifies a diff number, fetch diff details via mcp__plugin_meta_mux__get_phabricator_diff_details

Step 2: Determine Applicable FBOSS Reviewers

  • Files in agent/, SwSwitch, HwSwitch -> Agent Reviewer (#6)
  • Files in fsdb/, thrift_cow/ -> FSDB/thrift_cow Reviewer (#7)
  • Files in platform/, config, sensor/fan -> Platform Reviewer (#8)
  • Files in sai/, hw/sai/, SDK -> SAI/SDK Reviewer (#9)
  • Test files or coverage-affecting changes -> Testing Reviewer (#10)
  • Changes spanning SwSwitch + HwSwitch, new SwitchState fields, new counters, BUCK target changes, new client infrastructure, or 3+ directory scope -> Architect Reviewer (#11)

Step 3: Dispatch Reviewers in Parallel

Use Agent tool (sonnet model) to dispatch all applicable reviewers simultaneously:

  • Generic reviewers 1-5: ALWAYS dispatch. Use personas from references/generic-reviewers.md.
  • FBOSS reviewers 6-10: Dispatch ONLY if their area is touched.
  • Each reviewer receives: full diff content + their persona instructions.
  • FBOSS reviewers additionally load patterns from ../fboss-code-standards/references/<area>-patterns.md.
#ReviewerFocusPatterns File
1ReliabilityError handling, RAII, logging, timeout/retry, graceful degradation-
2Engineering / PerformanceAlgorithmic complexity, unnecessary copies, lock contention, modern C++-
3Code QualityReadability, modularity, duplication, API design../fboss-code-standards/references/general-patterns.md
4Summary & Test PlanTitle accuracy, summary completeness, test plan adequacy, diff coherence-
5Silent Failure FinderLogic errors, lossy conversions, race conditions, silent data loss-
6Agent ArchitectureMono/multi-switch, state management, warmboot, HwSwitch/SwSwitch boundary../fboss-code-standards/references/agent-patterns.md
7FSDB & thrift_cowState/Stats duality, COW node safety, subscriptions, build time../fboss-code-standards/references/thrift-cow-fsdb-patterns.md
8Platform & ConfigPlatform services, JSON configs, startup order, OSS sync../fboss-code-standards/references/platform-config-patterns.md
9SAI/SDK IntegrationSAI API usage, object lifecycle, vendor SDK compat, attributes../fboss-code-standards/references/sai-sdk-patterns.md
10Testing StandardsCoverage, naming, fixtures, NSDB impact, HW test patterns../fboss-code-standards/references/testing-patterns.md
11FBOSS ArchitectCross-cutting design: layering, state derivability, abstraction, code org, infra reusereferences/fboss-specific-reviewers.md

Step 4: Verification

Dispatch a single verifier agent (loads references/verifier.md) to:

  • Deduplicate findings across reviewers
  • Calibrate confidence scores
  • Filter false positives
  • Threshold: only report findings with confidence >= 0.7

Step 5: Present Findings

Output a structured report:

| File:Line | Reviewer | Severity | Issue | Confidence |
|-----------|----------|----------|-------|------------|

Never post findings to Phabricator.

When to Load References

TopicAction
Generic reviewer personasRead references/generic-reviewers.md
Verification/dedup logicRead references/verifier.md
FBOSS-specific reviewer personasRead references/fboss-specific-reviewers.md
Adding/modifying reviewersRead references/contributing.md