Definition Of Done
Testing & Qualitydefinition-of-doneDefinition Of Done is an Agent Skill for testing & quality published in the flutter/skills repository on GitHub: a SKILL.md instruction file an AI agent can load to do this task.
Mandatory checks to run before completing any task that touches md files or dart code in this repository.
QUICK START
How to use this skill
Bring this guide into your coding agent with a prompt tailored to the tool you use.
- Open your project in Codex.
- Copy and paste the prompt below.
- Review files and risks before approving any action.
Prompt to paste
Inspect the Agent Skill at https://github.com/flutter/skills/blob/HEAD/tool/dart_skills_lint/.agents/skills/definition-of-done/SKILL.md and all supporting files. Report provenance, permissions, scripts, dependencies, and security risks. Propose an exact installation into .agents/skills/definition-of-done, but wait for my approval before writing files or running scripts.
Copying this prompt does not install or run the skill. Review third-party files before use.
Definition of Done
Use this skill to ensure that all work meets the repository standards before declaring a task complete or requesting review.
📋 Mandatory Verification Steps
Before stating that a task is complete, you MUST execute and pass the following checks:
- Formatting: Run
dart format .to format files, ordart format --output=none --set-exit-if-changed .to check without modifying. Ensure all files are formatted correctly. - Analysis: Run
dart analyze --fatal-infosand ensure there are zero issues (including info-level issues). - Metrics/Linter: Run
dart run dart_code_linter:metrics analyze liband ensure there are zero issues. This checks for cyclomatic complexity and custom rules like file naming and redundant async. - Tests: Run
dart testand ensure all tests pass successfully. - Skill Validation: If any skill files were modified, run
dart run dart_skills_lint -d .agents/skillsto ensure they are valid. - Changelog: Ensure
CHANGELOG.mdis updated if the task includes user-facing features, bug fixes, or behavioral changes. - Temporal Words: Ensure that code and code comments contain no relative temporal terms (e.g., 'now', 'currently', 'new', 'old', 'existing behavior').
🚦 Completion Checklist
- Code is formatted (
dart format .or checked with--output=none --set-exit-if-changed .). - Analysis is clean (
dart analyze --fatal-infos). - Metrics/Linter are clean (
dart run dart_code_linter:metrics analyze lib). - Tests are passing (
dart test). - Skills validated if modified (
dart run dart_skills_lint -d .agents/skills). -
CHANGELOG.mdupdated for user-facing features, bug fixes, or behavioral changes. - Verified that code and code comments contain no relative temporal terms (e.g., 'now', 'currently', 'new', 'old', 'existing behavior').
- Documentation is updated.