OpenParable
Skip to content
← Back to skills

Definition Of Done

Testing & Quality
definition-of-done

Definition Of Done is an Agent Skill for testing & quality published in the flutter/skills repository on GitHub: a SKILL.md instruction file an AI agent can load to do this task.

Mandatory checks to run before completing any task that touches md files or dart code in this repository.

View on GitHub ↗
QUICK START

How to use this skill

Bring this guide into your coding agent with a prompt tailored to the tool you use.

  1. Open your project in Codex.
  2. Copy and paste the prompt below.
  3. Review files and risks before approving any action.
Prompt to paste
Inspect the Agent Skill at https://github.com/flutter/skills/blob/HEAD/tool/dart_skills_lint/.agents/skills/definition-of-done/SKILL.md and all supporting files. Report provenance, permissions, scripts, dependencies, and security risks. Propose an exact installation into .agents/skills/definition-of-done, but wait for my approval before writing files or running scripts.

Copying this prompt does not install or run the skill. Review third-party files before use.

Definition of Done

Use this skill to ensure that all work meets the repository standards before declaring a task complete or requesting review.

📋 Mandatory Verification Steps

Before stating that a task is complete, you MUST execute and pass the following checks:

  1. Formatting: Run dart format . to format files, or dart format --output=none --set-exit-if-changed . to check without modifying. Ensure all files are formatted correctly.
  2. Analysis: Run dart analyze --fatal-infos and ensure there are zero issues (including info-level issues).
  3. Metrics/Linter: Run dart run dart_code_linter:metrics analyze lib and ensure there are zero issues. This checks for cyclomatic complexity and custom rules like file naming and redundant async.
  4. Tests: Run dart test and ensure all tests pass successfully.
  5. Skill Validation: If any skill files were modified, run dart run dart_skills_lint -d .agents/skills to ensure they are valid.
  6. Changelog: Ensure CHANGELOG.md is updated if the task includes user-facing features, bug fixes, or behavioral changes.
  7. Temporal Words: Ensure that code and code comments contain no relative temporal terms (e.g., 'now', 'currently', 'new', 'old', 'existing behavior').

🚦 Completion Checklist

  • Code is formatted (dart format . or checked with --output=none --set-exit-if-changed .).
  • Analysis is clean (dart analyze --fatal-infos).
  • Metrics/Linter are clean (dart run dart_code_linter:metrics analyze lib).
  • Tests are passing (dart test).
  • Skills validated if modified (dart run dart_skills_lint -d .agents/skills).
  • CHANGELOG.md updated for user-facing features, bug fixes, or behavioral changes.
  • Verified that code and code comments contain no relative temporal terms (e.g., 'now', 'currently', 'new', 'old', 'existing behavior').
  • Documentation is updated.