Code Review Asm Xtensa
Testing & Qualitycode-review-asm-xtensaCode Review Asm Xtensa is an Agent Skill for testing & quality published in the FastLED/FastLED repository on GitHub: a SKILL.md instruction file an AI agent can load to do this task.
Review Xtensa assembly code for ESP32 platforms. Checks for critical errors in inline assembly, ABI compliance, and optimization opportunities. Use after modifying ESP32 assembly or inline asm code.
How to use this skill
Bring this guide into your coding agent with a prompt tailored to the tool you use.
- Open your project in Codex.
- Copy and paste the prompt below.
- Review files and risks before approving any action.
Inspect the Agent Skill at https://github.com/FastLED/FastLED/blob/HEAD/.claude/skills/code-review-asm-xtensa/SKILL.md and all supporting files. Report provenance, permissions, scripts, dependencies, and security risks. Propose an exact installation into .agents/skills/code-review-asm-xtensa, but wait for my approval before writing files or running scripts.
Copying this prompt does not install or run the skill. Review third-party files before use.
Perform comprehensive manual review of Xtensa assembly code in FastLED ESP32 platforms for correctness, ABI compliance, safety, and performance.
What Gets Checked
Critical Errors (Must Fix)
- E001: Invalid
movifor 32-bit addresses - E002: Wrong return instruction in interrupts
- E003: Missing
memwmemory barriers for MMIO writes - E004: Windowed ABI used in interrupt handlers
- E005: Unaligned memory access
- E006: Missing
IRAM_ATTRon interrupt handlers - E007: Mixed ABI usage in same function
Performance Warnings
- W001-W005: Load-use hazards, loop overhead, nesting depth, register pressure, dependency chains
Optimization Opportunities
- O001-O004: Array indexing, conditional moves, loop unrolling, code density
Search for Xtensa assembly code in git changes (inline asm and .S files) and perform deep analysis.