Nodejoiner Command
Developmentnodejoiner-commandNodejoiner Command is an Agent Skill for development published in the openshift/installer repository on GitHub: a SKILL.md instruction file an AI agent can load to do this task.
Describes the acceptance criteria, BDD tests and specific implementation details when developing a new feature (or fixing an issue) related to the node-joiner command.
How to use this skill
Bring this guide into your coding agent with a prompt tailored to the tool you use.
- Open your project in Codex.
- Copy and paste the prompt below.
- Review files and risks before approving any action.
Inspect the Agent Skill at https://github.com/openshift/installer/blob/HEAD/pkg/nodejoiner/.claude/skills/nodejoiner-command/SKILL.md and all supporting files. Report provenance, permissions, scripts, dependencies, and security risks. Propose an exact installation into .agents/skills/nodejoiner-command, but wait for my approval before writing files or running scripts.
Copying this prompt does not install or run the skill. Review third-party files before use.
Implementation details
The nodejoiner is a internal command (not meant to be used directly by the user) wrapped by the oc adm nodeimage command, to allow the user adding a new node to an existing target cluster by building an ISO. The command reuses most of the code of the Agent-based Installer, but since it follows a slightly different workflow
some differences have been implemented in the code (through the usage of the workflow.AgentWorkflowTypeAddNodes enum value).
The most important asset is the joiner.ClusterInfo, as it contains the logic to inspect the current target cluster and to extract the input configuration required by
the ABI assets to generate the add node ISO. So usually the target cluster is considered the authoritative source of truth for the configuration.
Testing
- To run just the unit tests, you must use
hack/go-test.sh - To run the specific node-joiner integration test, you must use only
hack/go-integration-test-nodejoiner.sh - Integration test prerequisites:
ocmust be installed and in$PATH. Install with:curl -L https://mirror.openshift.com/pub/openshift-v4/clients/ocp/stable/openshift-client-linux.tar.gz -o /tmp/oc.tar.gz && mkdir -p ~/.local/bin && tar -xzf /tmp/oc.tar.gz -C ~/.local/bin oc kubectl && rm /tmp/oc.tar.gz- Override
GOPATHto a writable location (the default/tmp/claude/gois not writable in containers):PATH=$HOME/.local/bin:$PATH GOPATH=$HOME/go hack/go-integration-test-nodejoiner.sh
Useful references
- https://github.com/openshift/enhancements/blob/master/enhancements/oc/day2-add-nodes.md. This the official
ocenhancement proposal to add a newoc adm nodeimagecommand for letting the user easily add a new node by building an ISO. Theoccommand is a thin wrapper of thenode-joinercommand. - https://github.com/openshift/oc/tree/main/pkg/cli/admin/nodeimage. The code repository for the
oc adm nodeimagecommands.
Supporting files
acceptance/coreos-bootimages-data.md: how to fetch the coreos bootimages data required for building the ISO.